mirror of
https://github.com/TheRealOwenRees/chess-endgame-trainer.git
synced 2026-11-18 03:32:06 +00:00
Admin panel, login throttling, and Cloudflare edge hardening (#150)
* Document the remote shell for production user management * add sitemap to footer links * remove border under theme selection * Add admin theme and user management (#144) Add /admin/themes CRUD and /admin/users list/detail with role and plan editing, guarded by a shared Policy module. Include last-super-admin and self-role protections plus structured id-only admin logs. Also add admin invitations, confirmation resends and password-reset emails, which work in development through the Swoosh mailbox before SES is configured. * Rate-limit password logins and emit auth events (#142) Add a two-bucket login throttle (5 failures per login, 10 per IP in a 15-minute window) and a shared client-address helper for controllers and LiveViews. Blocked attempts skip the database and bcrypt. Log auth.login.failed and auth.login.throttled warnings with boot-scoped HMAC addresses only, and stop repeated confirmation emails on unconfirmed login attempts. * Harden the production login edge for Cloudflare Document the layered login defence: the app throttle is primary, Caddy must pass Cloudflare's CF-Connecting-IP to the app, and Cloudflare edge rate limiting covers request floods. Update the reference Caddyfile to accept only Cloudflare ranges and reject direct-to-origin traffic, and document the exact Cloudflare dashboard rules. * Document 10-second Cloudflare rate-limit window Cloudflare may only offer a 10-second period. Keep the edge rule at 10 login POSTs per 10 seconds per IP and rely on the app's 15-minute login/address throttle for credential guessing. * Document Cloudflare limits for LiveView registration Registration submits over the shared LiveView socket, so a Cloudflare rule on POST /users/register will not count account creations. Note the app-level throttle/Turnstile options instead. * Document current Cloudflare free-plan edge controls Record the production setup: Cloudflare-only Caddy origins, Bot Fight Mode, and the 10-second login flood rule (10 POSTs per 10 seconds, 10-second block). Clarify that the application's 15-minute throttle remains the real credential lockout. * Auto-refresh Cloudflare CIDRs for Caddy Move the origin allowlist into a generated cloudflare-ranges.caddy imported by Caddy. Add an hourly systemd timer and script that fetch Cloudflare's v4/v6 lists, reject malformed responses, validate the candidate Caddyfile, and reload Caddy only when the ranges change. Restore the previous file on validation or reload failure. * Document Cloudflare CIDR refresher setup and operations Record the installed paths, permissions, timer checks, manual run, update procedure, and the direct-on-VPS setup fallback when the deploy directory is absent.
This commit is contained in:
@@ -1,7 +1,11 @@
|
||||
defmodule ChesstrainerWeb.UserSessionController do
|
||||
use ChesstrainerWeb, :controller
|
||||
|
||||
require Logger
|
||||
|
||||
alias Chesstrainer.Accounts
|
||||
alias ChesstrainerWeb.ClientAddress
|
||||
alias ChesstrainerWeb.LoginThrottle
|
||||
alias ChesstrainerWeb.UserAuth
|
||||
|
||||
def create(conn, %{"user" => user_params}) do
|
||||
@@ -17,32 +21,78 @@ defmodule ChesstrainerWeb.UserSessionController do
|
||||
end
|
||||
|
||||
defp authenticate(conn, user_params, failure_path, success_path) do
|
||||
%{"email" => login} = user_params
|
||||
address = ClientAddress.from_conn(conn)
|
||||
|
||||
case LoginThrottle.check(address, login) do
|
||||
:ok ->
|
||||
attempt_login(conn, address, user_params, failure_path, success_path)
|
||||
|
||||
{:throttled, bucket, retry_in_ms} ->
|
||||
log_auth_event("auth.login.throttled", address, reason: bucket)
|
||||
|
||||
conn
|
||||
|> put_flash(:error, throttle_message(retry_in_ms))
|
||||
|> redirect(to: failure_path)
|
||||
end
|
||||
end
|
||||
|
||||
defp attempt_login(conn, address, user_params, failure_path, success_path) do
|
||||
%{"email" => login, "password" => password} = user_params
|
||||
|
||||
case Accounts.get_user_by_login_and_password(login, password) do
|
||||
nil ->
|
||||
invalid_credentials(conn, login, failure_path)
|
||||
authentication_failed(conn, address, login, :invalid_credentials, failure_path)
|
||||
|
||||
user ->
|
||||
if user.confirmed_at do
|
||||
LoginThrottle.record_success(login)
|
||||
|
||||
conn
|
||||
|> maybe_put_return_to(success_path)
|
||||
|> put_flash(:info, "Welcome back!")
|
||||
|> UserAuth.log_in_user(user, user_params)
|
||||
else
|
||||
{:ok, _} =
|
||||
Accounts.deliver_user_confirmation_instructions(
|
||||
user,
|
||||
&url(~p"/users/confirm/#{&1}")
|
||||
)
|
||||
|
||||
# In order to prevent user enumeration attacks, report the same error
|
||||
# as invalid credentials.
|
||||
invalid_credentials(conn, login, failure_path)
|
||||
maybe_resend_confirmation(user, login)
|
||||
authentication_failed(conn, address, login, :unconfirmed, failure_path)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
defp maybe_resend_confirmation(user, login) do
|
||||
if LoginThrottle.claim_confirmation_resend(login) do
|
||||
case Accounts.deliver_user_confirmation_instructions(
|
||||
user,
|
||||
&url(~p"/users/confirm/#{&1}")
|
||||
) do
|
||||
{:ok, _email} -> :ok
|
||||
{:error, _reason} -> Logger.warning("auth.confirmation.resend_failed")
|
||||
end
|
||||
end
|
||||
|
||||
:ok
|
||||
end
|
||||
|
||||
defp authentication_failed(conn, address, login, reason, failure_path) do
|
||||
LoginThrottle.record_failure(address, login)
|
||||
log_auth_event("auth.login.failed", address, reason: reason)
|
||||
|
||||
# In order to prevent user enumeration attacks, report the same error as
|
||||
# invalid credentials.
|
||||
invalid_credentials(conn, login, failure_path)
|
||||
end
|
||||
|
||||
defp log_auth_event(message, address, metadata) do
|
||||
Logger.warning(message, Keyword.put(metadata, :ip, LoginThrottle.fingerprint(address)))
|
||||
end
|
||||
|
||||
defp throttle_message(retry_in_ms) do
|
||||
minutes = max(div(retry_in_ms + 59_999, 60_000), 1)
|
||||
unit = if minutes == 1, do: "minute", else: "minutes"
|
||||
|
||||
"Too many attempts. Try again in #{minutes} #{unit}."
|
||||
end
|
||||
|
||||
defp invalid_credentials(conn, login, path) do
|
||||
conn
|
||||
|> put_flash(:error, "Invalid email, username or password")
|
||||
|
||||
Reference in New Issue
Block a user