Add multi-theme tagging to endgames in the admin

#11: endgames can carry multiple themes (endgame tags) chosen from a
searchable, autocompleting picker with inline creation. Tags are staged
in the form and saved atomically, so they work on both New and Edit.

Tag names are trimmed and case-insensitively unique per category. Admin
Show and Index display themes, and the seeds ship a starter vocabulary.

The theme picker has its own form: LiveView requires phx-change inputs to
live inside a form, and a separate theme form keeps Enter from
submitting the endgame form.
This commit is contained in:
2026-11-01 22:22:09 +01:00
parent be23f1d7f8
commit 645f65f2a3
13 changed files with 403 additions and 150 deletions
+35
View File
@@ -3,6 +3,7 @@ defmodule Chesstrainer.EndgamesTest do
alias Chesstrainer.Endgames
alias Chesstrainer.Endgames.Endgame
alias Chesstrainer.Tags
describe "create_endgame/1 FEN validation" do
test "accepts a standard valid FEN" do
@@ -85,4 +86,38 @@ defmodule Chesstrainer.EndgamesTest do
assert msg =~ "active color"
end
end
describe "tags" do
test "create_endgame/2 associates themes" do
{:ok, tag} = Tags.create_tag(%{name: "Lucena", category: :endgame})
attrs = %{
fen: "8/8/3k4/8/8/3K1R2/8/8 w - - 0 1",
color: :white,
key: "KR v K",
result: :win,
rating: 1500
}
assert {:ok, endgame} = Endgames.create_endgame(attrs, [tag])
assert Enum.map(endgame.tags, & &1.id) == [tag.id]
end
test "update_endgame/3 replaces themes" do
{:ok, lucena} = Tags.create_tag(%{name: "Lucena", category: :endgame})
{:ok, philidor} = Tags.create_tag(%{name: "Philidor", category: :endgame})
attrs = %{
fen: "6k1/5p2/6p1/8/7p/8/6PP/6K1 b - - 0 1",
color: :black,
key: "KPPP v KPP",
result: :win,
rating: 1500
}
assert {:ok, endgame} = Endgames.create_endgame(attrs, [lucena])
assert {:ok, updated} = Endgames.update_endgame(endgame, %{rating: 1600}, [philidor])
assert Enum.map(updated.tags, & &1.id) == [philidor.id]
end
end
end
+18
View File
@@ -57,5 +57,23 @@ defmodule Chesstrainer.TagsTest do
tag = tag_fixture()
assert %Ecto.Changeset{} = Tags.change_tag(tag)
end
test "get_or_create/2 matches case-insensitively and trims" do
assert {:ok, tag} = Tags.get_or_create("Lucena", "endgame")
assert {:ok, found} = Tags.get_or_create(" lucena ", "endgame")
assert found.id == tag.id
assert length(Tags.list_tags()) == 1
end
test "get_or_create/2 rejects a blank name" do
assert {:error, :blank_name} = Tags.get_or_create(" ", "endgame")
end
test "create_tag/1 rejects a case-insensitive duplicate" do
assert {:ok, _tag} = Tags.create_tag(%{name: "Lucena", category: :endgame})
assert {:error, changeset} = Tags.create_tag(%{name: "lucena", category: :endgame})
assert changeset.errors[:name]
end
end
end
@@ -0,0 +1,83 @@
defmodule ChesstrainerWeb.EndgameLive.FormTest do
use ChesstrainerWeb.ConnCase
import Phoenix.LiveViewTest
import Chesstrainer.TagsFixtures
alias Chesstrainer.Endgames
alias Chesstrainer.Repo
alias Chesstrainer.Tags
@fen "8/8/3k4/8/8/3K1R2/8/8 w - - 0 1"
test "creates an endgame with staged themes", %{conn: conn} do
tag = tag_fixture(%{name: "Lucena"})
{:ok, view, _html} = live(conn, ~p"/admin/endgames/new")
view |> form("#theme-form", %{tag_search: "Luc"}) |> render_change()
view |> element("button", "Lucena") |> render_click()
view
|> form("#endgame-form",
endgame: %{fen: @fen, key: "KR v K", rating: 1500, result: "win"}
)
|> render_submit()
assert_redirect(view, ~p"/admin/endgames")
endgame =
Endgames.list_endgames()
|> Enum.find(&(&1.fen == @fen))
|> Repo.preload(:tags)
assert Enum.map(endgame.tags, & &1.id) == [tag.id]
end
test "attaches multiple themes", %{conn: conn} do
tag_fixture(%{name: "Lucena"})
tag_fixture(%{name: "Philidor"})
{:ok, view, _html} = live(conn, ~p"/admin/endgames/new")
view |> form("#theme-form", %{tag_search: "Luc"}) |> render_change()
view |> element("button", "Lucena") |> render_click()
view |> form("#theme-form", %{tag_search: "Phil"}) |> render_change()
view |> element("button", "Philidor") |> render_click()
html = render(view)
assert html =~ "Lucena"
assert html =~ "Philidor"
end
test "creates and attaches a new theme inline", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/endgames/new")
view |> form("#theme-form", %{tag_search: "Lucerne"}) |> render_submit()
assert render(view) =~ "Lucerne"
assert [%{name: "Lucerne"}] = Tags.search("Lucerne", "endgame")
end
test "removes a theme from an existing endgame", %{conn: conn} do
tag = tag_fixture(%{name: "Lucena"})
attrs = %{fen: @fen, color: :white, key: "KR v K", result: :win, rating: 1500}
{:ok, endgame} = Endgames.create_endgame(attrs, [tag])
{:ok, view, _html} = live(conn, ~p"/admin/endgames/#{endgame}/edit")
assert render(view) =~ "Lucena"
view |> element("button[aria-label='Remove Lucena']") |> render_click()
view
|> form("#endgame-form", endgame: %{key: "KR v K", rating: 1500, result: "win"})
|> render_submit()
assert_redirect(view, ~p"/admin/endgames")
updated = Endgames.get_endgame!(endgame.id) |> Repo.preload(:tags)
assert updated.tags == []
end
end
@@ -0,0 +1,19 @@
defmodule ChesstrainerWeb.EndgameLive.IndexTest do
use ChesstrainerWeb.ConnCase
import Phoenix.LiveViewTest
import Chesstrainer.EndgamesFixtures
import Chesstrainer.TagsFixtures
alias Chesstrainer.Endgames
test "lists an endgame's themes", %{conn: conn} do
tag = tag_fixture(%{name: "Lucena"})
endgame = endgame_fixture()
{:ok, _endgame} = Endgames.update_endgame(endgame, %{}, [tag])
{:ok, _view, html} = live(conn, ~p"/admin/endgames")
assert html =~ "Lucena"
end
end