From 6d0d750ca77eb4ee53dffee45c4ade83fa57511a Mon Sep 17 00:00:00 2001 From: Owen Date: Mon, 2 Nov 2026 21:26:19 +0100 Subject: [PATCH] Default new endgames to rating 1500 Closes #17 --- lib/chesstrainer/endgames/endgame.ex | 2 +- test/chesstrainer/endgames_test.exs | 8 +++++ .../live/endgame_live/form_test.exs | 34 +++++++++++++++++++ 3 files changed, 43 insertions(+), 1 deletion(-) diff --git a/lib/chesstrainer/endgames/endgame.ex b/lib/chesstrainer/endgames/endgame.ex index 695606a..9accf28 100644 --- a/lib/chesstrainer/endgames/endgame.ex +++ b/lib/chesstrainer/endgames/endgame.ex @@ -17,7 +17,7 @@ defmodule Chesstrainer.Endgames.Endgame do field :message, :string field :notes, :string field :result, Ecto.Enum, values: [:win, :loss, :draw] - field :rating, :integer + field :rating, :integer, default: 1500 field :rating_deviation, :integer field :times_attempted, :integer field :times_solved, :integer diff --git a/test/chesstrainer/endgames_test.exs b/test/chesstrainer/endgames_test.exs index eb2b5bb..a083366 100644 --- a/test/chesstrainer/endgames_test.exs +++ b/test/chesstrainer/endgames_test.exs @@ -150,6 +150,14 @@ defmodule Chesstrainer.EndgamesTest do end end + describe "rating default" do + test "a new endgame changeset defaults rating to 1500" do + changeset = Endgames.change_endgame(%Endgame{}) + + assert Ecto.Changeset.get_field(changeset, :rating) == 1500 + end + end + describe "listing and filtering" do test "list_keys/0 returns the distinct keys sorted" do create_endgame!(@kr) diff --git a/test/chesstrainer_web/live/endgame_live/form_test.exs b/test/chesstrainer_web/live/endgame_live/form_test.exs index f8e4f8f..09fd891 100644 --- a/test/chesstrainer_web/live/endgame_live/form_test.exs +++ b/test/chesstrainer_web/live/endgame_live/form_test.exs @@ -10,6 +10,40 @@ defmodule ChesstrainerWeb.EndgameLive.FormTest do @fen "8/8/3k4/8/8/3K1R2/8/8 w - - 0 1" + describe "rating default" do + test "new endgame form pre-fills rating with 1500", %{conn: conn} do + {:ok, view, _html} = live(conn, ~p"/admin/endgames/new") + + html = view |> element("#endgame-form input[name='endgame[rating]']") |> render() + + assert html =~ ~s(value="1500") + end + + test "creates an endgame rated 1500 when rating is left unchanged", %{conn: conn} do + {:ok, view, _html} = live(conn, ~p"/admin/endgames/new") + + view + |> form("#endgame-form", endgame: %{fen: @fen, result: "win"}) + |> render_submit() + + assert_redirect(view, ~p"/admin/endgames") + + endgame = Endgames.list_endgames() |> Enum.find(&(&1.fen == @fen)) + assert endgame.rating == 1500 + end + + test "editing an endgame keeps its stored rating", %{conn: conn} do + attrs = %{fen: @fen, color: :white, result: :win, rating: 1625} + {:ok, endgame} = Endgames.create_endgame(attrs) + + {:ok, view, _html} = live(conn, ~p"/admin/endgames/#{endgame}/edit") + + html = view |> element("#endgame-form input[name='endgame[rating]']") |> render() + + assert html =~ ~s(value="1625") + end + end + test "creates an endgame with staged themes", %{conn: conn} do theme = theme_fixture(%{name: "Lucena"})