mirror of
https://github.com/TheRealOwenRees/chess-endgame-trainer.git
synced 2026-11-18 03:32:06 +00:00
Implement tablebase parsing fixes and LFU cache
#5: normalise the full lichess tablebase category vocabulary (cursed-win and blessed-loss classify as draws), return {:ok, tablebase} on a cache hit, and unwrap the tablebase in game_from_fen. #6: replace the LRU cache with an LFU cache storing {key, value, frequency, last_access}, evicting the least-frequently-used entry (LRU tie-break) and halving every frequency on a weekly sweep. Persistence moves to a versioned v2 dets file, dropping the legacy backup; the cache restores synchronously at startup. Also updates stale tags enum and Play LiveView tests, and drops the tracked legacy cache backup.
This commit is contained in:
Vendored
+26
-11
@@ -1,25 +1,40 @@
|
||||
defmodule Chesstrainer.Cache.Evict do
|
||||
@moduledoc """
|
||||
Eviction functions for LRU cache
|
||||
Eviction for the LFU cache.
|
||||
"""
|
||||
|
||||
# O(n) time, not efficient
|
||||
def maybe_evict_oldest(table, max_size) do
|
||||
@doc """
|
||||
Evicts least-frequently-used entries until `table` holds at most `max_size`
|
||||
rows. Ties in frequency are broken by least recent use (`last_access`).
|
||||
"""
|
||||
def evict(table, max_size) do
|
||||
if :ets.info(table, :size) > max_size do
|
||||
case find_oldest_entry(table) do
|
||||
{oldest_key, _} -> :ets.delete(table, oldest_key)
|
||||
_ -> :ok
|
||||
case find_least_used_entry(table) do
|
||||
{key, _frequency, _last_access} ->
|
||||
:ets.delete(table, key)
|
||||
evict(table, max_size)
|
||||
|
||||
nil ->
|
||||
:ok
|
||||
end
|
||||
else
|
||||
:ok
|
||||
end
|
||||
end
|
||||
|
||||
defp find_oldest_entry(table) do
|
||||
defp find_least_used_entry(table) do
|
||||
:ets.foldl(
|
||||
fn {k, _v, t}, acc ->
|
||||
fn {k, _v, frequency, last_access}, acc ->
|
||||
case acc do
|
||||
nil -> {k, t}
|
||||
{_, oldest_t} when t < oldest_t -> {k, t}
|
||||
_ -> acc
|
||||
nil ->
|
||||
{k, frequency, last_access}
|
||||
|
||||
{_k, best_frequency, best_access}
|
||||
when {frequency, last_access} < {best_frequency, best_access} ->
|
||||
{k, frequency, last_access}
|
||||
|
||||
_ ->
|
||||
acc
|
||||
end
|
||||
end,
|
||||
nil,
|
||||
|
||||
Vendored
+39
-10
@@ -1,29 +1,58 @@
|
||||
defmodule Chesstrainer.Cache.Persist do
|
||||
@moduledoc """
|
||||
Persistance for cache. Backup and restore functions.
|
||||
Persistence for the cache. Backup and restore functions.
|
||||
"""
|
||||
|
||||
@backup_path "priv/static/backups"
|
||||
@format_version "v2"
|
||||
|
||||
def backup(table) do
|
||||
File.mkdir_p!(@backup_path)
|
||||
filename = Path.join(@backup_path, "#{table}.det") |> String.to_charlist()
|
||||
{:ok, dets_table} = :dets.open_file(filename, type: :set)
|
||||
name = backup_filename(table) |> String.to_charlist()
|
||||
{:ok, dets_table} = :dets.open_file(name, type: :set)
|
||||
:ets.to_dets(table, dets_table)
|
||||
:dets.sync(dets_table)
|
||||
:dets.close(dets_table)
|
||||
end
|
||||
|
||||
def restore(table) do
|
||||
File.mkdir_p!(@backup_path)
|
||||
filename = Path.join(@backup_path, "#{table}.det") |> String.to_charlist()
|
||||
drop_legacy_backup(table)
|
||||
|
||||
case :dets.open_file(table, file: filename, type: :set) do
|
||||
{:ok, ^table} ->
|
||||
:dets.foldl(fn entry, _ -> :ets.insert(table, entry) end, :ok, table)
|
||||
:dets.close(table)
|
||||
path = backup_filename(table)
|
||||
|
||||
{:error, _} ->
|
||||
:ok
|
||||
if File.exists?(path) do
|
||||
name = String.to_charlist(path)
|
||||
|
||||
case :dets.open_file(table, file: name, type: :set) do
|
||||
{:ok, ^table} ->
|
||||
:dets.foldl(
|
||||
fn
|
||||
{key, value, frequency, last_access}, :ok when is_integer(frequency) ->
|
||||
:ets.insert(table, {key, value, frequency, last_access})
|
||||
:ok
|
||||
|
||||
_entry, :ok ->
|
||||
:ok
|
||||
end,
|
||||
:ok,
|
||||
table
|
||||
)
|
||||
|
||||
:dets.close(table)
|
||||
|
||||
{:error, _} ->
|
||||
:ok
|
||||
end
|
||||
end
|
||||
|
||||
:ok
|
||||
end
|
||||
|
||||
defp backup_filename(table), do: Path.join(@backup_path, "#{table}.#{@format_version}.det")
|
||||
|
||||
defp drop_legacy_backup(table) do
|
||||
legacy = Path.join(@backup_path, "#{table}.det")
|
||||
if File.exists?(legacy), do: File.rm(legacy)
|
||||
end
|
||||
end
|
||||
|
||||
Vendored
+25
@@ -0,0 +1,25 @@
|
||||
defmodule Chesstrainer.Cache.Sweep do
|
||||
@moduledoc """
|
||||
Frequency decay for the LFU cache.
|
||||
|
||||
Halving every frequency each week lets entries that were used heavily once but
|
||||
have not been used since age out of the cache.
|
||||
"""
|
||||
|
||||
@doc """
|
||||
Halves the frequency of every entry in `table` with integer division, so an
|
||||
entry used once decays from `1` to `0`.
|
||||
"""
|
||||
def halve_frequencies(table) do
|
||||
:ets.foldl(
|
||||
fn {key, value, frequency, last_access}, :ok ->
|
||||
:ets.insert(table, {key, value, div(frequency, 2), last_access})
|
||||
:ok
|
||||
end,
|
||||
:ok,
|
||||
table
|
||||
)
|
||||
|
||||
:ok
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user