mirror of
https://github.com/TheRealOwenRees/chess-endgame-trainer.git
synced 2026-11-18 11:42:07 +00:00
Implement tablebase parsing fixes and LFU cache
#5: normalise the full lichess tablebase category vocabulary (cursed-win and blessed-loss classify as draws), return {:ok, tablebase} on a cache hit, and unwrap the tablebase in game_from_fen. #6: replace the LRU cache with an LFU cache storing {key, value, frequency, last_access}, evicting the least-frequently-used entry (LRU tie-break) and halving every frequency on a weekly sweep. Persistence moves to a versioned v2 dets file, dropping the legacy backup; the cache restores synchronously at startup. Also updates stale tags enum and Play LiveView tests, and drops the tracked legacy cache backup.
This commit is contained in:
+66
-39
@@ -1,6 +1,12 @@
|
||||
defmodule Chesstrainer.Cache do
|
||||
@moduledoc """
|
||||
Generic LRU cache.
|
||||
Generic LFU cache with a periodic frequency-decay sweep.
|
||||
|
||||
Entries are stored in ETS as `{key, value, frequency, last_access}`. Reads bump
|
||||
the frequency; when the cache is over its maximum size the least frequently
|
||||
used entry is evicted (ties broken by least recent use). A weekly sweep halves
|
||||
every frequency so entries that were used heavily once but have not been used
|
||||
since eventually age out.
|
||||
|
||||
## Examples
|
||||
|
||||
@@ -9,14 +15,21 @@ defmodule Chesstrainer.Cache do
|
||||
|
||||
use GenServer
|
||||
|
||||
@max_size 1000
|
||||
@default_max_size 1000
|
||||
@default_sweep_interval :timer.hours(24 * 7)
|
||||
@backup_interval_minutes 60
|
||||
|
||||
def start_link(table), do: GenServer.start_link(__MODULE__, table, name: via_tuple(table))
|
||||
def start_link(table), do: start_link(table, [])
|
||||
|
||||
def start_link(table, opts) when is_list(opts) do
|
||||
GenServer.start_link(__MODULE__, {table, opts}, name: via_tuple(table))
|
||||
end
|
||||
|
||||
def put(table, key, value), do: GenServer.call(via_tuple(table), {:put, key, value})
|
||||
def get(table, key), do: GenServer.call(via_tuple(table), {:get, key})
|
||||
def delete(table, key), do: GenServer.call(via_tuple(table), {:delete, key})
|
||||
def backup(table), do: GenServer.cast(via_tuple(table), :backup)
|
||||
def backup(table), do: GenServer.call(via_tuple(table), :backup)
|
||||
def sweep(table), do: GenServer.call(via_tuple(table), :sweep)
|
||||
|
||||
def show(table) do
|
||||
ensure_table(table)
|
||||
@@ -26,66 +39,76 @@ defmodule Chesstrainer.Cache do
|
||||
def size(table), do: :ets.info(table, :size)
|
||||
|
||||
@impl true
|
||||
def init(table) do
|
||||
{:ok, table, {:continue, :restore_and_backup}}
|
||||
end
|
||||
def init({table, opts}) do
|
||||
state = %{
|
||||
table: table,
|
||||
max_size: Keyword.get(opts, :max_size, @default_max_size),
|
||||
sweep_interval: Keyword.get(opts, :sweep_interval, @default_sweep_interval)
|
||||
}
|
||||
|
||||
@impl true
|
||||
def handle_continue(:restore_and_backup, table) do
|
||||
# Create and restore synchronously so the cache is never observed empty
|
||||
# between `start_link/1` returning and the restore finishing.
|
||||
create_table(table)
|
||||
__MODULE__.Persist.restore(table)
|
||||
__MODULE__.Evict.evict(table, state.max_size)
|
||||
:timer.send_interval(:timer.minutes(@backup_interval_minutes), :backup)
|
||||
{:noreply, table}
|
||||
:timer.send_interval(state.sweep_interval, :sweep)
|
||||
|
||||
{:ok, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_call({:put, key, value}, _from, table) do
|
||||
ensure_table(table)
|
||||
timestamp = System.system_time(:millisecond)
|
||||
:ets.insert(table, {key, value, timestamp})
|
||||
|
||||
GenServer.cast(self(), :maybe_evict)
|
||||
|
||||
{:reply, :ok, table}
|
||||
def handle_call({:put, key, value}, _from, state) do
|
||||
ensure_table(state.table)
|
||||
access = System.system_time(:microsecond)
|
||||
:ets.insert(state.table, {key, value, 1, access})
|
||||
__MODULE__.Evict.evict(state.table, state.max_size)
|
||||
{:reply, :ok, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_call({:get, key}, _from, table) do
|
||||
ensure_table(table)
|
||||
def handle_call({:get, key}, _from, state) do
|
||||
ensure_table(state.table)
|
||||
|
||||
case :ets.lookup(table, key) do
|
||||
[{^key, value, _old_timestamp}] ->
|
||||
timestamp = System.system_time(:millisecond)
|
||||
:ets.insert(table, {key, value, timestamp})
|
||||
{:reply, {:ok, value}, table}
|
||||
case :ets.lookup(state.table, key) do
|
||||
[{^key, value, frequency, _old_access}] ->
|
||||
access = System.system_time(:microsecond)
|
||||
:ets.insert(state.table, {key, value, frequency + 1, access})
|
||||
{:reply, {:ok, value}, state}
|
||||
|
||||
[] ->
|
||||
{:reply, :error, table}
|
||||
{:reply, :error, state}
|
||||
end
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_call({:delete, key}, _from, table) do
|
||||
:ets.delete(table, key)
|
||||
{:reply, :ok, table}
|
||||
def handle_call({:delete, key}, _from, state) do
|
||||
:ets.delete(state.table, key)
|
||||
{:reply, :ok, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_cast(:maybe_evict, table) do
|
||||
__MODULE__.Evict.maybe_evict_oldest(table, @max_size)
|
||||
{:noreply, table}
|
||||
def handle_call(:backup, _from, state) do
|
||||
__MODULE__.Persist.backup(state.table)
|
||||
{:reply, :ok, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_cast(:backup, table) do
|
||||
__MODULE__.Persist.backup(table)
|
||||
{:noreply, table}
|
||||
def handle_call(:sweep, _from, state) do
|
||||
__MODULE__.Sweep.halve_frequencies(state.table)
|
||||
{:reply, :ok, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_info(:backup, table) do
|
||||
GenServer.cast(self(), :backup)
|
||||
{:noreply, table}
|
||||
def handle_info(:backup, state) do
|
||||
__MODULE__.Persist.backup(state.table)
|
||||
{:noreply, state}
|
||||
end
|
||||
|
||||
@impl true
|
||||
def handle_info(:sweep, state) do
|
||||
__MODULE__.Sweep.halve_frequencies(state.table)
|
||||
{:noreply, state}
|
||||
end
|
||||
|
||||
defp via_tuple(table), do: {:via, Registry, {Chesstrainer.CacheRegistry, table}}
|
||||
@@ -97,5 +120,9 @@ defmodule Chesstrainer.Cache do
|
||||
end
|
||||
end
|
||||
|
||||
defp create_table(table), do: :ets.new(table, [:named_table, :public, :set])
|
||||
defp create_table(table) do
|
||||
:ets.new(table, [:named_table, :public, :set])
|
||||
rescue
|
||||
ArgumentError -> table
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user