Show tablebase moves during review (#65) (#102)

* engine 8+ tablebase adr

* Show tablebase moves during review (#65)

- group reviewed moves by winning/drawn/losing and make each row playable
- move review navigation under the board with start/end jumps
- give review a full-height scrollable tablebase pane
This commit is contained in:
2026-11-06 15:31:11 +01:00
committed by GitHub
parent bd8be4d10d
commit b17f346b25
7 changed files with 382 additions and 153 deletions
@@ -167,6 +167,12 @@ defmodule ChesstrainerWeb.EndgameLive.GuestTrain do
def handle_event("review_step", %{"index" => index}, socket),
do: PlayCore.review_step(socket, index)
def handle_event("review_start", _params, socket), do: PlayCore.review_start(socket)
def handle_event("review_end", _params, socket), do: PlayCore.review_end(socket)
def handle_event("review_move", params, socket), do: PlayCore.review_move(socket, params)
def handle_event("play_best_line", _params, socket), do: PlayCore.play_best_line(socket)
def handle_event("best_line_move_applied", params, socket),
@@ -85,6 +85,12 @@ defmodule ChesstrainerWeb.EndgameLive.Play do
def handle_event("review_step", %{"index" => index}, socket),
do: PlayCore.review_step(socket, index)
def handle_event("review_start", _params, socket), do: PlayCore.review_start(socket)
def handle_event("review_end", _params, socket), do: PlayCore.review_end(socket)
def handle_event("review_move", params, socket), do: PlayCore.review_move(socket, params)
def handle_event("play_best_line", _params, socket), do: PlayCore.play_best_line(socket)
def handle_event("best_line_move_applied", params, socket),
@@ -46,7 +46,7 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
|> assign(:review_tablebase, nil)
|> assign(:review_blocked, nil)
|> assign(:awaiting_best_line, false)
|> assign(:pending_best_move, nil)
|> assign(:pending_move, nil)
|> assign(:last_san, "None yet")
|> assign(:last_from_to, "None yet")
|> assign(:last_grade, nil)
@@ -135,7 +135,7 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
|> assign(:review_tablebase, nil)
|> assign(:review_blocked, nil)
|> assign(:awaiting_best_line, false)
|> assign(:pending_best_move, nil)
|> assign(:pending_move, nil)
|> assign(:last_san, "None yet")
|> assign(:last_from_to, "None yet")
|> assign(:last_grade, nil)
@@ -162,6 +162,10 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
def review_next(socket), do: step_review(socket, 1)
def review_start(socket), do: review_step(socket, 0)
def review_end(socket), do: review_step(socket, length(socket.assigns.line))
def review_step(socket, index) do
if socket.assigns.reviewing do
last = length(socket.assigns.line)
@@ -177,21 +181,41 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
with true <- socket.assigns.reviewing,
%Tablebase{} = tablebase <- socket.assigns.review_tablebase,
%Tablebase.Move{} = move <- pick_best_move(tablebase) do
# Branch the review line at the current position, then play one best move.
{:noreply,
socket
|> assign(:line, Enum.take(socket.assigns.line, socket.assigns.review_index))
|> assign(:awaiting_best_line, true)
|> assign(:pending_best_move, move)
|> push_event("best_line_move", reply_payload(move))}
play_review_move(socket, move, true)
else
_ -> {:noreply, socket}
end
end
@doc """
Plays one tablebase move from the reviewed position, branching the line.
The move comes from a `phx-value-uci` on the tablebase table.
"""
def review_move(socket, %{"uci" => uci}) do
with true <- socket.assigns.reviewing,
%Tablebase{} = tablebase <- socket.assigns.review_tablebase,
%Tablebase.Move{} = move <- find_move_by_uci(tablebase, uci) do
play_review_move(socket, move, false)
else
_ -> {:noreply, socket}
end
end
# Branch the review line at the current position, then ask the board to play
# the move; `best_line_move_applied/2` appends it once chess.js confirms it.
defp play_review_move(socket, move, best_line?) do
{:noreply,
socket
|> assign(:line, Enum.take(socket.assigns.line, socket.assigns.review_index))
|> assign(:awaiting_best_line, true)
|> assign(:pending_move, %{move: move, best_line: best_line?})
|> push_event("best_line_move", reply_payload(move))}
end
def best_line_move_applied(socket, %{"fen" => fen}) do
if socket.assigns.awaiting_best_line do
move = socket.assigns.pending_best_move
%{move: move, best_line: best_line?} = socket.assigns.pending_move
line =
socket.assigns.line ++
@@ -201,7 +225,8 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
san: move.san,
fen_after: fen,
grade: nil,
best_line: true
analysis: true,
best_line: best_line?
}
]
@@ -209,7 +234,7 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
socket
|> assign(:line, line)
|> assign(:awaiting_best_line, false)
|> assign(:pending_best_move, nil)
|> assign(:pending_move, nil)
|> set_review_index(length(line))
{:noreply, push_review_position(socket)}
@@ -489,6 +514,12 @@ defmodule ChesstrainerWeb.EndgameLive.PlayCore do
defp find_move(_tablebase, _from, _to, _promotion), do: nil
defp find_move_by_uci(%Tablebase{moves: moves}, uci) when is_list(moves) do
Enum.find(moves, &(&1.uci == uci))
end
defp find_move_by_uci(_tablebase, _uci), do: nil
# Compare only the board and side to move: chess.js may normalise the rest
# (castling/en-passant/halfmove/fullmove) differently from the stored FEN.
defp same_position?(fen_a, fen_b), do: position_key(fen_a) == position_key(fen_b)
@@ -269,6 +269,12 @@ defmodule ChesstrainerWeb.EndgameLive.Train do
def handle_event("review_step", %{"index" => index}, socket),
do: PlayCore.review_step(socket, index)
def handle_event("review_start", _params, socket), do: PlayCore.review_start(socket)
def handle_event("review_end", _params, socket), do: PlayCore.review_end(socket)
def handle_event("review_move", params, socket), do: PlayCore.review_move(socket, params)
def handle_event("play_best_line", _params, socket), do: PlayCore.play_best_line(socket)
def handle_event("best_line_move_applied", params, socket),