Derive canonical material Key from the FEN

The Endgame key is now a canonical, colour-agnostic material signature derived
from the FEN instead of a hand-typed field: each side's pieces, strongest side
first by material value (e.g. "KQ v KR"). This fixes the seed ordering
inconsistency and guarantees the key always matches the position.

- Add Chesstrainer.Key.from_fen/1.
- Compute the key in the Endgame changeset; drop the manual input and its
  regex validation.
- Index endgames.key and derive keys in the seeds.
- Document the Key term and the decision (ADR 0003).

Closes #13
This commit is contained in:
2026-11-02 09:22:01 +01:00
parent cd2e7f0164
commit ca65207baa
12 changed files with 258 additions and 47 deletions
@@ -20,7 +20,7 @@ defmodule ChesstrainerWeb.EndgameLive.FormTest do
view
|> form("#endgame-form",
endgame: %{fen: @fen, key: "KR v K", rating: 1500, result: "win"}
endgame: %{fen: @fen, rating: 1500, result: "win"}
)
|> render_submit()
@@ -62,7 +62,7 @@ defmodule ChesstrainerWeb.EndgameLive.FormTest do
test "removes a theme from an existing endgame", %{conn: conn} do
theme = theme_fixture(%{name: "Lucena"})
attrs = %{fen: @fen, color: :white, key: "KR v K", result: :win, rating: 1500}
attrs = %{fen: @fen, color: :white, result: :win, rating: 1500}
{:ok, endgame} = Endgames.create_endgame(attrs, [theme])
{:ok, view, _html} = live(conn, ~p"/admin/endgames/#{endgame}/edit")
@@ -72,7 +72,7 @@ defmodule ChesstrainerWeb.EndgameLive.FormTest do
view |> element("button[aria-label='Remove Lucena']") |> render_click()
view
|> form("#endgame-form", endgame: %{key: "KR v K", rating: 1500, result: "win"})
|> form("#endgame-form", endgame: %{rating: 1500, result: "win"})
|> render_submit()
assert_redirect(view, ~p"/admin/endgames")
@@ -78,7 +78,14 @@ defmodule ChesstrainerWeb.EndgameLive.PlayTest do
end
test "shows endgame metadata in the header", %{conn: conn} do
endgame = endgame_fixture(key: "KQ v K", color: :white, result: :win, rating: 1800)
endgame =
endgame_fixture(
fen: "8/8/3k4/8/8/3K1Q2/8/8 w - - 0 1",
color: :white,
result: :win,
rating: 1800
)
seed_tablebase(endgame.fen)
{:ok, _view, html} = live(conn, ~p"/endgames/#{endgame}/play")