Launch amendments: one login, crawler policy, and asset caching (#180)

* lesson library shown as com,ing soon. re-enable learngin strip

* replace learning strip text with a lasker quote

* remove admin login endpoint

* fix crawler directives and prelaunch login

- noindex the authenticated scope and the 404 catch-all, and cover the
  mailing-list confirmation redirect
- emit noindex, nofollow from the robots meta and /health, and assert
  public pages stay indexable and followable
- stop inventing lastmod values in the sitemap
- log in through /users/log-in during prelaunch now that the admin login
  endpoint is gone; drop create_admin/2 and its orphaned tests

* update caching length to 1 year - name change will invalidate cache

* remove logger

* fix tablebase path breaking tests

* test: check cache headers without requiring built assets

CI's test job does not run mix assets.build, so /assets/css/app.css is a
404 there. Committed piece art is already content-hashed and takes the same
Plug.Static cache option, so the test no longer needs a build step and
passes on a fresh checkout.
This commit is contained in:
2026-11-17 12:55:47 +01:00
committed by GitHub
parent 37e0ac8e56
commit fa1fef7b62
21 changed files with 157 additions and 94 deletions
@@ -3,7 +3,7 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta :if={assigns[:noindex]} name="robots" content="noindex" />
<meta :if={assigns[:noindex]} name="robots" content="noindex, nofollow" />
<meta name="csrf-token" content={get_csrf_token()} />
<.live_title
@@ -10,7 +10,7 @@ defmodule ChesstrainerWeb.HealthController do
status = if health.status == "down", do: :service_unavailable, else: :ok
conn
|> put_resp_header("x-robots-tag", "noindex")
|> put_resp_header("x-robots-tag", "noindex, nofollow")
|> put_status(status)
|> json(health)
end
@@ -40,8 +40,11 @@
</div>
</section>
<%!-- <section class="learning-strip" id="method">
<p>Built for the part of chess that decides everything.</p>
<section class="learning-strip" id="method">
<figure class="learning-quote">
<blockquote>“The hardest game to win is a won game.”</blockquote>
<figcaption>— Emmanuel Lasker</figcaption>
</figure>
<div class="stat">
<strong>{count_label(@puzzle_count)}</strong>
<span>puzzles</span>
@@ -50,9 +53,9 @@
<strong>{@user_count}</strong>
<span>Players improving their endgame</span>
</div>
</section> --%>
</section>
<%!-- <section class="puzzle-section" id="puzzles">
<section class="puzzle-section" id="puzzles">
<div class="section-heading">
<div>
<span class="section-kicker">Choose your lesson</span>
@@ -65,16 +68,16 @@
that you’ll recognise over the board.
</p>
</div>
<div class="puzzle-grid">
<%= for {endgame, index} <- Enum.with_index(@endgames) do %>
<.puzzle_card
endgame={endgame}
index={index}
active={@active_endgame && endgame.id == @active_endgame.id}
/>
<% end %>
<div class="puzzle-coming-soon">
<div class="eyebrow">
<.icon_spark /> Coming soon
</div>
<strong>The lesson library is on its way.</strong>
<p>
A growing set of positions, each teaching one idea. Today’s puzzle is already live.
</p>
</div>
</section> --%>
</section>
<.mailing_list_signup :if={@mailing_list_enabled} />
@@ -6,19 +6,20 @@ defmodule ChesstrainerWeb.SitemapController do
them and they render the same interactive surface with only the position
differing, so listing them all would be index bloat. Revisit that if public
browse pages (by Key or theme) exist and are worth ranking.
No `<lastmod>` is emitted: none of these pages has a stored modification time,
and an invented date (such as "today" on every request) teaches crawlers to
distrust the sitemap.
"""
use ChesstrainerWeb, :controller
def index(conn, _params) do
# The landing page changes every day (daily puzzle, counts), so its
# lastmod is honest. The legal pages have no stored modification time, and
# an invented lastmod is worse than none.
entries = [
{url(conn, ~p"/"), Date.utc_today()},
{url(conn, ~p"/privacy"), nil},
{url(conn, ~p"/terms-conditions"), nil},
{url(conn, ~p"/mentions-legales"), nil}
url(conn, ~p"/"),
url(conn, ~p"/privacy"),
url(conn, ~p"/terms-conditions"),
url(conn, ~p"/mentions-legales")
]
conn
@@ -28,8 +29,8 @@ defmodule ChesstrainerWeb.SitemapController do
defp render_sitemap(entries) do
urls =
Enum.map_join(entries, fn {loc, lastmod} ->
" <url><loc>#{escape(loc)}</loc>#{lastmod_entry(lastmod)}</url>\n"
Enum.map_join(entries, fn loc ->
" <url><loc>#{escape(loc)}</loc></url>\n"
end)
"""
@@ -39,9 +40,6 @@ defmodule ChesstrainerWeb.SitemapController do
"""
end
defp lastmod_entry(nil), do: ""
defp lastmod_entry(%Date{} = date), do: "<lastmod>#{Date.to_iso8601(date)}</lastmod>"
# Templates escape automatically; this response is built as a plain string,
# so XML-significant characters must be escaped here.
defp escape(value) do
@@ -12,14 +12,6 @@ defmodule ChesstrainerWeb.UserSessionController do
authenticate(conn, user_params, ~p"/users/log-in", nil)
end
def create_admin(conn, %{"user" => user_params}) do
if ChesstrainerWeb.prelaunch?() do
authenticate(conn, user_params, ~p"/admin/log-in", ~p"/admin/endgames")
else
authenticate(conn, user_params, ~p"/users/log-in", nil)
end
end
defp authenticate(conn, user_params, failure_path, success_path) do
%{"email" => login} = user_params
address = ClientAddress.from_conn(conn)
+7 -1
View File
@@ -19,12 +19,18 @@ defmodule ChesstrainerWeb.Endpoint do
#
# When code reloading is disabled (e.g., in production),
# the `gzip` option is enabled to serve compressed
# static files generated by running `phx.digest`.
# static files generated by running `phx.digest`, and the cache headers promise
# a year. Build output is digested, and the stable-name assets (fonts, piece
# art, icons) only change when the file is renamed, so a long max-age is safe
# and keeps browsers and the CDN off the origin. Dev keeps plain `public` so
# edits show up immediately.
plug Plug.Static,
at: "/",
from: :chesstrainer,
gzip: not code_reloading?,
only: ChesstrainerWeb.static_paths(),
cache_control_for_etags:
if(code_reloading?, do: "public", else: "public, max-age=31536000, immutable"),
raise_on_missing_only: code_reloading?
# Code reloading can be explicitly enabled under the
+2 -7
View File
@@ -27,7 +27,7 @@ defmodule ChesstrainerWeb.UserLive.Login do
:let={f}
for={@form}
id="login_form_password"
action={@login_action}
action={~p"/users/log-in"}
phx-submit="submit_password"
phx-trigger-action={@trigger_submit}
>
@@ -75,17 +75,12 @@ defmodule ChesstrainerWeb.UserLive.Login do
get_in(socket.assigns, [:current_scope, Access.key(:user), Access.key(:email)])
form = to_form(%{"email" => email}, as: "user")
prelaunch = ChesstrainerWeb.prelaunch?()
login_action =
if prelaunch, do: ~p"/admin/log-in", else: ~p"/users/log-in"
{:ok,
assign(socket,
form: form,
trigger_submit: false,
prelaunch: prelaunch,
login_action: login_action
prelaunch: ChesstrainerWeb.prelaunch?()
)}
end
+1 -1
View File
@@ -19,6 +19,7 @@ defmodule ChesstrainerWeb.Plugs.Prelaunch do
/health
/robots.txt
/sitemap.xml
/users/log-in
/favicon.ico
/favicon.svg
/favicon-16x16.png
@@ -40,7 +41,6 @@ defmodule ChesstrainerWeb.Plugs.Prelaunch do
/assets
/fonts
/images
/dev
)
def init(opts), do: opts
+3 -5
View File
@@ -36,8 +36,6 @@ defmodule ChesstrainerWeb.Router do
get "/terms-conditions", PageController, :terms_conditions
get "/mentions-legales", PageController, :mentions_legales
post "/mailing-list", MailingListController, :create
get "/mailing-list/confirm/:token", MailingListController, :confirm
post "/admin/log-in", UserSessionController, :create_admin
end
scope "/admin", ChesstrainerWeb do
@@ -89,7 +87,7 @@ defmodule ChesstrainerWeb.Router do
## Authentication routes
scope "/", ChesstrainerWeb do
pipe_through [:browser, :require_authenticated_user]
pipe_through [:browser, :noindex, :require_authenticated_user]
live_session :require_authenticated_user,
on_mount: [
@@ -124,12 +122,12 @@ defmodule ChesstrainerWeb.Router do
live "/endgames/:public_code/play", EndgameLive.Play, :play
live "/users/register", UserLive.Registration, :new
live "/users/log-in", UserLive.Login, :new
live "/admin/log-in", UserLive.Login, :new
live "/users/reset-password", UserLive.ResetPassword, :new
live "/users/reset-password/:token", UserLive.ResetPassword, :edit
end
get "/users/confirm/:token", UserConfirmationController, :edit
get "/mailing-list/confirm/:token", MailingListController, :confirm
post "/users/log-in", UserSessionController, :create
delete "/users/log-out", UserSessionController, :delete
@@ -148,7 +146,7 @@ defmodule ChesstrainerWeb.Router do
# Keep this last: routes match in definition order. It gives unmatched paths a
# branded 404 page with the site chrome instead of Phoenix's bare status page.
scope "/", ChesstrainerWeb do
pipe_through :browser
pipe_through [:browser, :noindex]
match :*, "/*path", PageController, :not_found
end