Launch amendments: one login, crawler policy, and asset caching (#180)

* lesson library shown as com,ing soon. re-enable learngin strip

* replace learning strip text with a lasker quote

* remove admin login endpoint

* fix crawler directives and prelaunch login

- noindex the authenticated scope and the 404 catch-all, and cover the
  mailing-list confirmation redirect
- emit noindex, nofollow from the robots meta and /health, and assert
  public pages stay indexable and followable
- stop inventing lastmod values in the sitemap
- log in through /users/log-in during prelaunch now that the admin login
  endpoint is gone; drop create_admin/2 and its orphaned tests

* update caching length to 1 year - name change will invalidate cache

* remove logger

* fix tablebase path breaking tests

* test: check cache headers without requiring built assets

CI's test job does not run mix assets.build, so /assets/css/app.css is a
404 there. Committed piece art is already content-hashed and takes the same
Plug.Static cache option, so the test no longer needs a build step and
passes on a fresh checkout.
This commit is contained in:
2026-11-17 12:55:47 +01:00
committed by GitHub
parent 37e0ac8e56
commit fa1fef7b62
21 changed files with 157 additions and 94 deletions
@@ -6,19 +6,20 @@ defmodule ChesstrainerWeb.SitemapController do
them and they render the same interactive surface with only the position
differing, so listing them all would be index bloat. Revisit that if public
browse pages (by Key or theme) exist and are worth ranking.
No `<lastmod>` is emitted: none of these pages has a stored modification time,
and an invented date (such as "today" on every request) teaches crawlers to
distrust the sitemap.
"""
use ChesstrainerWeb, :controller
def index(conn, _params) do
# The landing page changes every day (daily puzzle, counts), so its
# lastmod is honest. The legal pages have no stored modification time, and
# an invented lastmod is worse than none.
entries = [
{url(conn, ~p"/"), Date.utc_today()},
{url(conn, ~p"/privacy"), nil},
{url(conn, ~p"/terms-conditions"), nil},
{url(conn, ~p"/mentions-legales"), nil}
url(conn, ~p"/"),
url(conn, ~p"/privacy"),
url(conn, ~p"/terms-conditions"),
url(conn, ~p"/mentions-legales")
]
conn
@@ -28,8 +29,8 @@ defmodule ChesstrainerWeb.SitemapController do
defp render_sitemap(entries) do
urls =
Enum.map_join(entries, fn {loc, lastmod} ->
" <url><loc>#{escape(loc)}</loc>#{lastmod_entry(lastmod)}</url>\n"
Enum.map_join(entries, fn loc ->
" <url><loc>#{escape(loc)}</loc></url>\n"
end)
"""
@@ -39,9 +40,6 @@ defmodule ChesstrainerWeb.SitemapController do
"""
end
defp lastmod_entry(nil), do: ""
defp lastmod_entry(%Date{} = date), do: "<lastmod>#{Date.to_iso8601(date)}</lastmod>"
# Templates escape automatically; this response is built as a plain string,
# so XML-significant characters must be escaped here.
defp escape(value) do