Launch amendments: one login, crawler policy, and asset caching (#180)

* lesson library shown as com,ing soon. re-enable learngin strip

* replace learning strip text with a lasker quote

* remove admin login endpoint

* fix crawler directives and prelaunch login

- noindex the authenticated scope and the 404 catch-all, and cover the
  mailing-list confirmation redirect
- emit noindex, nofollow from the robots meta and /health, and assert
  public pages stay indexable and followable
- stop inventing lastmod values in the sitemap
- log in through /users/log-in during prelaunch now that the admin login
  endpoint is gone; drop create_admin/2 and its orphaned tests

* update caching length to 1 year - name change will invalidate cache

* remove logger

* fix tablebase path breaking tests

* test: check cache headers without requiring built assets

CI's test job does not run mix assets.build, so /assets/css/app.css is a
404 there. Committed piece art is already content-hashed and takes the same
Plug.Static cache option, so the test no longer needs a build step and
passes on a fresh checkout.
This commit is contained in:
2026-11-17 12:55:47 +01:00
committed by GitHub
parent 37e0ac8e56
commit fa1fef7b62
21 changed files with 157 additions and 94 deletions
@@ -1,8 +1,6 @@
defmodule Chesstrainer.AccountsAdminTest do
use Chesstrainer.DataCase, async: false
require Logger
import Chesstrainer.AccountsFixtures
import ExUnit.CaptureLog
import Swoosh.TestAssertions
@@ -10,7 +10,7 @@ defmodule ChesstrainerWeb.HealthControllerTest do
assert body["db"] == "ok"
assert body["tablebase"] == "local"
assert body["process"] == "ok"
assert get_resp_header(conn, "x-robots-tag") == ["noindex"]
assert get_resp_header(conn, "x-robots-tag") == ["noindex, nofollow"]
end
test "returns degraded when local tablebases are not configured", %{conn: conn} do
@@ -53,7 +53,7 @@ defmodule ChesstrainerWeb.HealthControllerTest do
assert body["db"] == "down"
assert body["tablebase"] == "local"
assert body["process"] == "ok"
assert get_resp_header(conn, "x-robots-tag") == ["noindex"]
assert get_resp_header(conn, "x-robots-tag") == ["noindex, nofollow"]
end
end
@@ -68,10 +68,17 @@ defmodule ChesstrainerWeb.PageControllerTest do
assert LazyHTML.text(LazyHTML.query(document, "title")) =~ Branding.home_title()
refute html =~ "Phoenix Framework"
eyebrow = LazyHTML.query(document, ".eyebrow")
eyebrow = LazyHTML.query(document, ".hero .eyebrow")
assert LazyHTML.text(eyebrow) =~ "Endgames, simplified"
assert LazyHTML.attribute(LazyHTML.query(eyebrow, "svg"), "aria-hidden") == ["true"]
assert LazyHTML.text(LazyHTML.query(document, ".puzzle-coming-soon")) =~ "Coming soon"
assert LazyHTML.text(LazyHTML.query(document, ".learning-quote")) =~
"The hardest game to win is a won game."
assert html =~ "Emmanuel Lasker"
assert LazyHTML.attribute(LazyHTML.query(document, ~s(meta[name="description"])), "content") ==
[@description]
@@ -381,7 +388,7 @@ defmodule ChesstrainerWeb.PageControllerTest do
refute html =~ "Browse puzzles"
assert html =~ ~s(class="site-footer")
assert html =~ "/assets/js/marketing.js"
assert html =~ ~s(name="robots")
assert html =~ ~s(<meta name="robots" content="noindex, nofollow")
end
test "premium users see the puzzles link on the 404 page", %{conn: conn} do
@@ -11,17 +11,16 @@ defmodule ChesstrainerWeb.SitemapControllerTest do
assert body =~ ~s(<?xml version="1.0" encoding="UTF-8"?>)
assert body =~ ~s(<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">)
assert body =~ "<loc>#{base_url}/</loc>"
assert body =~ "<lastmod>#{Date.utc_today() |> Date.to_iso8601()}</lastmod>"
assert body =~ "<loc>#{base_url}/privacy</loc>"
assert body =~ "<loc>#{base_url}/terms-conditions</loc>"
assert body =~ "<loc>#{base_url}/mentions-legales</loc>"
assert length(:binary.matches(body, "<url>")) == 4
end
test "only dates the landing page", %{conn: conn} do
test "does not invent modification dates", %{conn: conn} do
body = conn |> get(~p"/sitemap.xml") |> response(200)
assert length(:binary.matches(body, "<lastmod>")) == 1
refute body =~ "<lastmod>"
end
test "is served as XML", %{conn: conn} do
@@ -186,22 +186,6 @@ defmodule ChesstrainerWeb.UserSessionControllerTest do
assert get_session(conn, :user_token)
end
test "the admin login uses the same throttle", %{conn: conn, user: user} do
for _ <- 1..LoginThrottle.max_per_login() do
post(conn, ~p"/admin/log-in", %{
"user" => %{"email" => user.email, "password" => "wrong password"}
})
end
conn =
post(conn, ~p"/admin/log-in", %{
"user" => %{"email" => user.email, "password" => valid_user_password()}
})
refute get_session(conn, :user_token)
assert Phoenix.Flash.get(conn.assigns.flash, :error) =~ "Too many attempts."
end
test "log events contain no raw address or password", %{conn: conn, user: user} do
log =
capture_log(
@@ -0,0 +1,45 @@
defmodule ChesstrainerWeb.CrawlerDirectivesTest do
use ChesstrainerWeb.ConnCase, async: true
@noindex "noindex, nofollow"
describe "X-Robots-Tag" do
test "authenticated routes are noindex even when redirecting to log in", %{conn: conn} do
conn = get(conn, ~p"/train")
assert redirected_to(conn) == ~p"/users/log-in"
assert get_resp_header(conn, "x-robots-tag") == [@noindex]
end
test "the branded 404 page is noindex", %{conn: conn} do
conn = get(conn, "/this-page-does-not-exist")
assert html_response(conn, 404)
assert get_resp_header(conn, "x-robots-tag") == [@noindex]
end
test "the mailing-list confirmation redirect is noindex", %{conn: conn} do
conn = get(conn, "/mailing-list/confirm/oops")
assert redirected_to(conn) == "/#mailing-list"
assert get_resp_header(conn, "x-robots-tag") == [@noindex]
end
test "public pages are not marked noindex", %{conn: conn} do
for path <- [~p"/", ~p"/privacy", ~p"/terms-conditions", ~p"/mentions-legales"] do
conn = get(conn, path)
html = html_response(conn, 200)
assert get_resp_header(conn, "x-robots-tag") == []
refute html =~ ~s(name="robots")
refute html =~ "nofollow"
end
end
test "pages that assign :noindex carry the same policy as the header", %{conn: conn} do
html = conn |> get("/this-page-does-not-exist") |> html_response(404)
assert html =~ ~s(<meta name="robots" content="#{@noindex}")
end
end
end
+12 -15
View File
@@ -14,12 +14,12 @@ defmodule ChesstrainerWeb.Plugs.PrelaunchTest do
:ok
end
test "allows the public pages, legal pages, health, and admin login", %{conn: conn} do
test "allows the public pages, legal pages, health, and login", %{conn: conn} do
assert conn |> get(~p"/") |> html_response(200)
assert conn |> get(~p"/privacy") |> html_response(200)
assert conn |> get(~p"/terms-conditions") |> html_response(200)
assert conn |> get(~p"/health") |> response(200)
assert conn |> get(~p"/admin/log-in") |> html_response(200)
assert conn |> get(~p"/users/log-in") |> html_response(200)
end
test "hides public auth links and start training", %{conn: conn} do
@@ -30,29 +30,26 @@ defmodule ChesstrainerWeb.Plugs.PrelaunchTest do
refute html =~ "Start training"
end
test "the hidden admin login uses the admin form action", %{conn: conn} do
html = conn |> get(~p"/admin/log-in") |> html_response(200)
test "the prelaunch login form posts to the public login route", %{conn: conn} do
html = conn |> get(~p"/users/log-in") |> html_response(200)
assert html =~ ~s(action="/admin/log-in")
assert html =~ ~s(action="/users/log-in")
refute html =~ "Sign up"
end
test "pauses the public login route", %{conn: conn} do
assert conn |> get(~p"/users/log-in") |> redirected_to() == "/"
end
test "admin login redirects to the admin area", %{conn: conn} do
user =
test "an admin can log in through the public login route", %{conn: conn} do
admin =
user_fixture()
|> Ecto.Changeset.change(role: :admin)
|> Repo.update!()
conn =
post(conn, ~p"/admin/log-in",
user: %{email: user.email, password: "hello world!", remember_me: "true"}
post(conn, ~p"/users/log-in",
user: %{email: admin.email, password: "hello world!", remember_me: "true"}
)
assert redirected_to(conn) == "/admin/endgames"
assert get_session(conn, :user_token)
assert get_resp_header(conn, "x-robots-tag") == ["noindex, nofollow"]
end
test "redirects blocked routes to the home page", %{conn: conn} do
@@ -84,7 +81,7 @@ defmodule ChesstrainerWeb.Plugs.PrelaunchTest do
end
test "blocks registration reached through LiveView navigation", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/log-in")
{:ok, view, _html} = live(conn, ~p"/users/log-in")
assert {:error, {:redirect, %{to: "/"}}} =
live_redirect(view, to: ~p"/users/register")
@@ -0,0 +1,28 @@
defmodule ChesstrainerWeb.StaticCacheTest do
use ChesstrainerWeb.ConnCase, async: true
# One year, matching `Plug.Static` in the endpoint when code reloading is off.
# A missing max-age here lets the CDN fall back to its own short default.
@one_year "public, max-age=31536000, immutable"
# Piece art is committed already hashed, so it is shaped like digested build
# output without requiring `mix assets.build` first (CI's test job does not
# build assets). The endpoint sets one cache option for every static file.
@digested_piece "/images/pieces/white/king-27fd3307056d10dae685faf4ca8f4488.svg"
test "digested assets are cached for a year", %{conn: conn} do
conn = get(conn, @digested_piece)
assert conn.status == 200
assert get_resp_header(conn, "cache-control") == [@one_year]
end
test "stable-name assets are cached for a year", %{conn: conn} do
for path <- ["/fonts/dm-sans-variable.woff2", "/images/og.png", "/favicon.svg"] do
conn = get(conn, path)
assert conn.status == 200
assert get_resp_header(conn, "cache-control") == [@one_year]
end
end
end